-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
House page #15246
House page #15246
Conversation
def initialize(country:, house:) | ||
@country = country | ||
@house = house | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't need to instantiate with both of these. Passing just the house
would be cleaner, and the country
can trivially be derived from that.
There's a lot of duplication now between this template and the country one. Unlike #15245, where the plan is to delete the per-country download page anyway, resolving the issue, I'm much less convinced it's OK here. We'll have two pages that are almost identical and it's going to be very easy to forget to change one when the other changes. |
d63f8ca
to
ff5dbe4
Compare
ff5dbe4
to
b805992
Compare
👍 — except we can't merge before #15245, as the pages here have a link to the (not yet existing) download page for the legislature. |
This PR adds a new page class for a legislature.
Page::House
class and tests/:country/:house/
)