Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#70] 마이페이지 api 연동 #71

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

seongh06
Copy link
Collaborator

  • closed #issue number

⛳️ Work Description

  • 프로필 수정 로직 변경
  • community랑 viewingparty 마이페이지에서 안보이도록 처리

📸 Screenshot

📢 To Reviewers

@seongh06 seongh06 added FEAT ✨ 기능 개발 김승혁 labels Oct 16, 2024
@seongh06 seongh06 self-assigned this Oct 16, 2024
@seongh06 seongh06 linked an issue Oct 16, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@hyowon0204 hyowon0204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kyujin0911 kyujin0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇가지 수정사항만 반영해주시면 될거 같아요
수고하셨어요!! 👍

Comment on lines +1 to +7
package umc.everyones.lck.domain.model.mypage

data class MyComment(
val id: Int,
val content: String,
val postType: String
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain -> model -> response -> mypage로 옮게주세요!

Comment on lines +1 to +9
package umc.everyones.lck.domain.model.mypage

import java.io.Serializable

data class MyPost(
val id: Int,
val title: String,
val postType: String
): Serializable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain -> model -> response -> mypage로 옮게주세요!

Comment on lines +21 to +23
override fun onBackPressed() {
// super.onBackPressed()
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필요없는 코드는 지워주세요!

Comment on lines +147 to +149
val result = runCatching {
repository.updateProfiles(updateProfileRequestModel.profileImage, updateProfileRequestModel)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repositoryImpl에서 이미 runCatching으로 잡았으니 굳이 또 안잡아도 됩니다 만약에 여기말고 다른데도 이렇게 되어있으면 다 수정해주세요!

Comment on lines 195 to 196
runCatching {
repository.updateTeam(updateTeamModel).onSuccess { response ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마찬가지로 runCatching으로 또 안잡아도 됩니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 마이페이지 API 연동
3 participants