+1,927
−422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kyujin0911
reviewed
Oct 17, 2024
Comment on lines
+1
to
+7
| package umc.everyones.lck.domain.model.mypage | ||
|
|
||
| data class MyComment( | ||
| val id: Int, | ||
| val content: String, | ||
| val postType: String | ||
| ) |
There was a problem hiding this comment.
domain -> model -> response -> mypage로 옮게주세요!
Comment on lines
+1
to
+9
| package umc.everyones.lck.domain.model.mypage | ||
|
|
||
| import java.io.Serializable | ||
|
|
||
| data class MyPost( | ||
| val id: Int, | ||
| val title: String, | ||
| val postType: String | ||
| ): Serializable |
There was a problem hiding this comment.
domain -> model -> response -> mypage로 옮게주세요!
Comment on lines
+21
to
+23
| override fun onBackPressed() { | ||
| // super.onBackPressed() | ||
| } |
Comment on lines
+147
to
+149
| val result = runCatching { | ||
| repository.updateProfiles(updateProfileRequestModel.profileImage, updateProfileRequestModel) | ||
| } |
There was a problem hiding this comment.
repositoryImpl에서 이미 runCatching으로 잡았으니 굳이 또 안잡아도 됩니다 만약에 여기말고 다른데도 이렇게 되어있으면 다 수정해주세요!
Comment on lines
195
to
196
| runCatching { | ||
| repository.updateTeam(updateTeamModel).onSuccess { response -> |
There was a problem hiding this comment.
마찬가지로 runCatching으로 또 안잡아도 됩니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
📢 To Reviewers