Skip to content

Assume one-time donation if no frequency selected #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markulrich merged 1 commit into from
Sep 25, 2025
Merged

Assume one-time donation if no frequency selected #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions ...es/donate-button-v4/src/components/widget/components/PaymentProcess/DefaultFlow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,11 @@ import {
import {useConfigContext} from 'src/components/widget/hooks/useConfigContext';
import {useSubmitDonation} from 'src/components/widget/hooks/useSubmitDonation';
import {useWidgetContext} from 'src/components/widget/hooks/useWidgetContext';
import {OneTimeFrequencyMethods} from 'src/components/widget/types/PaymentMethod';
import {getSubmitButtonText} from 'src/helpers/getSubmitButtonText';

export const DefaultFlow = () => {
const {frequency: fixedFrequency, amount: fixedAmount} = useConfigContext();
const {
frequency,
donationAmount,
selectedPaymentMethod,
paymentRequestAvailable,
Expand All @@ -48,13 +46,7 @@ export const DefaultFlow = () => {
<PublicTestimony />
<ErrorMessage message={submitError} />
<SubmitButton
disabled={
(!frequency &&
!fixedFrequency &&
!OneTimeFrequencyMethods.includes(selectedPaymentMethod)) ||
!donationAmount ||
Number.isNaN(donationAmount)
}
disabled={!donationAmount || Number.isNaN(donationAmount)}
>
{getSubmitButtonText({
method: selectedPaymentMethod,
Expand Down
2 changes: 2 additions & 0 deletions packages/donate-button-v4/src/helpers/constructDonateUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ export function constructDonateUrl({
amount,
...rest
}: DonateUrlParams) {
// If frequency is "" or undefined, default to one-time
frequency ||= DonationFrequency.OneTime;
const baseUrl = getBaseUrl(rest);
const params = getBaseParams(rest);

Expand Down