feat(cli): add --remove-language and language add/remove e2e#193
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds language-removal support to the Ballast wrapper’s monorepo install flow so users can drop one or more configured languages, persist the updated .rulesrc.json, and prune stale Ballast-managed rule files.
Changes:
- Add
--remove-languagehandling in the wrapper monorepo planner, including validation and cleanup-only execution paths. - Update CLI help text and documentation to describe language removal behavior.
- Add unit + e2e coverage for adding a language, validating install artifacts, removing it, and validating cleanup.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/e2e-add-remove-language-existing-install.sh | New e2e script exercising add/remove language and filesystem/config cleanup. |
| README.md | Document --remove-language and clarify wrapper install behavior. |
| docs/installation.md | Mirror docs updates for --remove-language. |
| cli/ballast/main.go | Implement parsing/validation of --remove-language, monorepo plan filtering, and flag stripping. |
| cli/ballast/main_test.go | Add unit tests covering cleanup-only plan creation and end-to-end wrapper cleanup behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| trap 'rm -rf "${WORKDIR}"' EXIT | ||
|
|
||
| # shellcheck source=./e2e/helpers.sh | ||
| source "${REPO_ROOT}/scripts/e2e/helpers.sh" |
Comment on lines
+922
to
+943
| func parseRemoveLanguageValues(args []string) []string { | ||
| return findFlagValues(args, "--remove-language", "") | ||
| } | ||
|
|
||
| func validateSelectedLanguages(values []string) error { | ||
| if len(values) == 0 { | ||
| return nil | ||
| } | ||
| allowed := map[string]struct{}{} | ||
| for _, lang := range supportedLanguages { | ||
| allowed[string(lang)] = struct{}{} | ||
| } | ||
| for _, value := range values { | ||
| if _, ok := allowed[value]; !ok { | ||
| return fmt.Errorf( | ||
| "invalid --remove-language: %s (valid: %s)", | ||
| value, | ||
| strings.Join(languageNames(), ", "), | ||
| ) | ||
| } | ||
| } | ||
| return nil |
| } | ||
| cleanupOnly := len(removeTargets) > 0 && len(requestedTargets) == 0 && !explicitAgentSelection && !explicitSkillSelection | ||
| if !cleanupOnly && (len(requestedTargets) == 0 || ((len(installAgents) == 0 && !installAll) && (len(installSkills) == 0 && !installAllSkills))) { | ||
| languageCleanupOnly := len(removeLanguages) > 0 && !explicitAgentSelection && !explicitSkillSelection |
| @@ -0,0 +1,53 @@ | |||
| #!/usr/bin/env bash | |||
Comment on lines
+15
to
+16
| - id: end-of-file-fixer | ||
| - id: trailing-whitespace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation