remove NGINX_FILES_PATH #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if this path are blank, the nginx Files are stored to the current path `$PWD/data`
|
Hello @mr-bolle Thanks for your PR. But my understanding on is that the user must know, set and understand where it should be located. |
|
You could improve the readme and .env file to explain it better for the user also set |
change the default nginx path
|
Thanks! |
nicolailang
added a commit
to nicolailang/docker-compose-letsencrypt-nginx-proxy-companion
that referenced
this pull request
Nov 29, 2018
update NGINX_FILES_PATH (evertramos#108)
joe307bad
added a commit
to joe307bad/docker-compose-letsencrypt-nginx-proxy-companion
that referenced
this pull request
Jan 16, 2020
* master: Update README.md (evertramos#178) update error message Get start script to create .env file for new users update nginx.template Update README.md Add Beerpay's badge Reload Instructions update nginx.tmpl file Fix issue evertramos#113 (evertramos#124) update realip address with private intranets options Update README.md update folder name Support for running on Synology DSM Nas and configureable ports for docker host (evertramos#110) update NGINX_FILES_PATH (evertramos#108) Update README.md Update .env.sample Update README.md # Conflicts: # nginx.tmpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if this path are blank, the nginx Files are stored to the current path
$PWD/data