The schema location is not always computed correctly for ReferenceSchema

[octavianN]

Hello,

1. I made a simple test that assets the schema location for a JSON Schema that has a reference to an external "definitions.json" schema.
   Please note that the schema location for the "city" schema is "#/properties/billing_address/properties/city". But this location does not exists.
   Maybe the location should be something like this: "#definitions.json/definitions/address/properties/city".

@Test
    public void testGetSchemaLocation() throws Exception {
      String definitions = "{\n" + 
          "  \"definitions\": {\n" + 
          "    \"address\": {\n" + 
          "      \"type\": \"object\",\n" + 
          "      \"properties\": {\n" + 
          "        \"city\":           { \"type\": \"string\" },\n" + 
          "        \"state\":          { \"type\": \"string\" }\n" + 
          "      }\n" +
          "    }\n" + 
          "  }\n" + 
          "}";
      
      Reader schema = new StringReader("{\n" + 
          "  \"properties\": {\n" + 
          "    \"billing_address\": { \"$ref\": \"definitions.json#/definitions/address\" }\n" + 
          "  }\n" + 
          "}");
      JSONObject schemaJson = new JSONObject(new JSONTokener(schema));
      
      SchemaClient httpClient = new SchemaClient() {
        @Override
        public InputStream get(String url) {
          if ("definitions.json".equals(url)) {
            return new ByteArrayInputStream(definitions.getBytes());
          }
          return null;
        }
      };
      ObjectSchema compiledSchema = (ObjectSchema) SchemaLoader.load(schemaJson, httpClient);
      
      assertEquals("#", compiledSchema.getSchemaLocation());
      
      ReferenceSchema billing_addresSchema = (ReferenceSchema) compiledSchema.getPropertySchemas().get("billing_address");
      assertEquals(null, billing_addresSchema.getSchemaLocation());
      ObjectSchema referredSchema = (ObjectSchema) billing_addresSchema.getReferredSchema();
      assertEquals("#/properties/billing_address", referredSchema.getSchemaLocation());
      
      Schema citySchema = referredSchema.getPropertySchemas().get("city");
      assertEquals("#/properties/billing_address/properties/city", citySchema.getSchemaLocation());
    }

[octavianN]

Another problem is that if the referred definition is in the same file, the reference schema has the location null, and the referred schema has the location of the referred definition. See the test case below.
Maybe the reference schema should have the location "#/properties/billing_address".

@Test
   public void testGetSchemaLocation2() throws Exception {
     Reader schema = new StringReader("{\n" + 
         "    \"properties\": {\n" + 
         "        \"billing_address\": {\"$ref\": \"#/definitions/address\"}\n" + 
         "    },\n" + 
         "    \"definitions\": {\n" + 
         "        \"address\": {\n" + 
         "            \"type\": \"object\",\n" + 
         "            \"properties\": {\n" + 
         "                \"city\": {\"type\": \"string\"},\n" + 
         "                \"state\": {\"type\": \"string\"}\n" + 
         "            }\n" + 
         "        }\n" + 
         "    }\n" + 
         "}");
     JSONObject schemaJson = new JSONObject(new JSONTokener(schema));
     ObjectSchema compiledSchema = (ObjectSchema) SchemaLoader.load(schemaJson);
     
     assertEquals("#", compiledSchema.getSchemaLocation());
     
     ReferenceSchema billing_addresSchema = (ReferenceSchema) compiledSchema.getPropertySchemas().get("billing_address");
     assertEquals(null, billing_addresSchema.getSchemaLocation());
     ObjectSchema referredSchema = (ObjectSchema) billing_addresSchema.getReferredSchema();
     assertEquals("#/definitions/address", referredSchema.getSchemaLocation());
   }

[erosb]

Hello @octavianN , thank you for reporting it. It is now fixed on current master, and will be included in the next release.