DEVPROD-6472: Create isRepo and repoPermissions resolvers
#8456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reduce admin_project_access power
Kimchelly
approved these changes
Nov 7, 2024
| usr, err := user.FindOneById(obj.UserID) | ||
| if err != nil { | ||
| return nil, ResourceNotFound.Send(ctx, "user not found") | ||
| } |
There was a problem hiding this comment.
Need to nil check usr since FindOneById returns nil, nil when not found.
graphql/permissions_resolver.go
Outdated
| func (r *permissionsResolver) RepoPermissions(ctx context.Context, obj *Permissions, options RepoPermissionsOptions) (*RepoPermissions, error) { | ||
| usr, err := user.FindOneById(obj.UserID) | ||
| if err != nil { | ||
| return nil, ResourceNotFound.Send(ctx, "user not found") |
There was a problem hiding this comment.
This seems like an InternalServerError since FindOneById would only error if the DB produced an error other than not found.
sophstad
approved these changes
Nov 7, 2024
minnakt
changed the title
isRepo and repoPermissions resolvers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-6472
Description
Creates two resolvers:
query.isRepo: A query that we can pass an ID to determine if something is a repo. This is helpful because the UI route for repos and projects is/project/<project_or_repo_id>/settingsso it's not possible for us to easily determine if something is a repo.user.repoPermissions: A query that returns if user has view or edit permission for a given repo. Note that the view repo role has been removed recently. A repo is instead considered to be viewable is a user has view access to any of its attached projects.I also updated the scopes / roles and reduced the power of
admin_project_accessrole (to mirror what is in production already).Testing