DEVPROD-7600 Add patch/version description to the task otel attributes #8455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimchelly
requested changes
Nov 6, 2024
Kimchelly
approved these changes
Nov 7, 2024
rest/route/service.go
Outdated
| @@ -103,7 +103,8 @@ func AttachHandler(app *gimlet.APIApp, opts HandlerOpts) { | |||
| app.AddRoute("/task/{task_id}/set_results_info").Version(2).Post().Wrap(requireTask).RouteHandler(makeSetTaskResultsInfoHandler()) | |||
| app.AddRoute("/task/{task_id}/start").Version(2).Post().Wrap(requireTask, requirePodOrHost).RouteHandler(makeStartTask(env)) | |||
| app.AddRoute("/task/{task_id}/test_logs").Version(2).Post().Wrap(requireTask, requirePodOrHost).RouteHandler(makeAttachTestLog(settings)) | |||
| app.AddRoute("/task/{task_id}/git/patch").Version(2).Get().Wrap(requireTask).RouteHandler(makeGitServePatch()) | |||
| app.AddRoute("/task/{task_id/patch").Version(2).Get().Wrap(requireTask).RouteHandler(makeServePatch()) | |||
There was a problem hiding this comment.
We have to maintain temporary backward compatibility for agents that are collecting task data but are still on the old agent version because those old agents still request the patch from /task/{task_id}/git/patch. An easy way to do this is to temporarily keep the /task/{task_id}/git/patch route while still introducing the new /task/{task_id}/patch route. Then once this is deployed and the agents have rolled over, remove /task/{task_id}/git/patch in a follow-up PR.
There was a problem hiding this comment.
That sounds good to me!
rest/route/service.go
Outdated
| @@ -103,7 +103,8 @@ func AttachHandler(app *gimlet.APIApp, opts HandlerOpts) { | |||
| app.AddRoute("/task/{task_id}/set_results_info").Version(2).Post().Wrap(requireTask).RouteHandler(makeSetTaskResultsInfoHandler()) | |||
| app.AddRoute("/task/{task_id}/start").Version(2).Post().Wrap(requireTask, requirePodOrHost).RouteHandler(makeStartTask(env)) | |||
| app.AddRoute("/task/{task_id}/test_logs").Version(2).Post().Wrap(requireTask, requirePodOrHost).RouteHandler(makeAttachTestLog(settings)) | |||
| app.AddRoute("/task/{task_id}/git/patch").Version(2).Get().Wrap(requireTask).RouteHandler(makeGitServePatch()) | |||
| app.AddRoute("/task/{task_id/patch").Version(2).Get().Wrap(requireTask).RouteHandler(makeServePatch()) | |||
There was a problem hiding this comment.
Also, the {task_id part of the route needs a closing curly brace!
There was a problem hiding this comment.
Thank you for the catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-7600
Description
This adds the patch/version description to the task otel attributes.
It adds the version route to get a version for agents, adds it to the communicator, and calls it if the patch isn't gotten (which it is for github PR's/github merge queue patch tasks, so we avoid double querying for the patch/version as much as possible)
Testing
New task here
Existing task here
(Search up version.description in the root span 'task')