Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Product Type / Product Category Preview thumbnail #8249

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

samuelmbabhazi
Copy link
Contributor

@samuelmbabhazi samuelmbabhazi commented Sep 24, 2024

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


@samuelmbabhazi samuelmbabhazi linked an issue Sep 24, 2024 that may be closed by this pull request
4 tasks
@samuelmbabhazi samuelmbabhazi marked this pull request as ready for review September 24, 2024 16:00
Copy link

nx-cloud bot commented Sep 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3036d98. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@evereq evereq merged commit 56018f6 into develop Sep 24, 2024
19 checks passed
@evereq evereq deleted the fix/#5052-upload-image-preview branch September 24, 2024 18:20
evereq added a commit that referenced this pull request Sep 24, 2024
* feat: add today's start and end date to timer status request

* [Fix] Calculated stopped date for Start/Stop timer (#8246)

* fix: updated time log create command/handler

* fix: build issue

* fix: calculated stopped date for stop timer

* fix: missing last time logs slots

* fix: close previous running timer entries

- When stop (/api/timesheet/timer/stop) endpoint hit, we will close last time log entry along with all pending previous timer entries

* fix: moment utc

* fix: updated schedule time log entries command

* fix: added example for each case

* fix(deepscan):  without null check prior

* [Perf] Introduce server side pagination for tasks table and Lazy loading (#8243)

* feat: create routing for tabs

* feat: improve lanaguage service

* feat: create cached server data server

* feat: caching task for 24 hours

* feat: add new observable to `selectorService`

* feat: change modidier private to public

* feat: improve create task dialog

* feat: create task table features

* feat: replace table with router tabset

* fix: deepscan

* Fix/#5052 preview thumbnail (#8249)

---------

Co-authored-by: Kifungo A <45813955+adkif@users.noreply.github.com>
Co-authored-by: Rahul R. <rahulrathore576@gmail.com>
Co-authored-by: samuel mbabhazi <111171386+samuelmbabhazi@users.noreply.github.com>
@samuelmbabhazi
Copy link
Contributor Author

I commented on this code because this button had no action associated with it, and I do not find its use. (See the code at this link.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Product Type / Product Category
2 participants