Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/1597 seed #1701

Merged
merged 6 commits into from
Jul 13, 2020
Merged

Feat/1597 seed #1701

merged 6 commits into from
Jul 13, 2020

Conversation

evereq
Copy link
Member

@evereq evereq commented Jul 13, 2020

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


@PoojaShah9
Copy link
Contributor

@evereq Please check this now. I have committed changes you mentioned.

@evereq
Copy link
Member Author

evereq commented Jul 13, 2020

@PoojaShah9 are you sure you check that code builds? Because this is what CircleCI found during API build:

ERROR in /tmp/workspace/api/apps/api/src/app/tags/tag.seed.ts
 
ERROR in /tmp/workspace/api/apps/api/src/app/tags/tag.seed.ts(50,49):
 
TS2552: Cannot find name 'defaultTags'. Did you mean 'defaultStatus'?
 

 
ERROR in /tmp/workspace/api/apps/api/src/app/time-off-policy/time-off-policy.seed.ts
 
ERROR in /tmp/workspace/api/apps/api/src/app/time-off-policy/time-off-policy.seed.ts(46,3):
 
TS2355: A function whose declared type is neither 'void' nor 'any' must return a value.
 

Please fix to make sure CircleCI succeed to build everything

@PoojaShah9 PoojaShah9 requested a review from rmagon July 13, 2020 14:12
@PoojaShah9 PoojaShah9 marked this pull request as ready for review July 13, 2020 14:13
@PoojaShah9
Copy link
Contributor

@evereq you can check it now

@evereq evereq merged commit eb5b733 into develop Jul 13, 2020
@evereq evereq deleted the feat/1597-seed branch July 13, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants