Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optionally disable customer's order cancelation #1198

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

valiopld
Copy link
Contributor

@valiopld valiopld commented Jul 6, 2020

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


ever-co/feature-requests#56
in the options dropdown list - "Ordering" is replaced with "After Ordering" - after recording the video

The feat is added only in /shopweb

@evereq
Copy link
Member

evereq commented Jul 6, 2020

@valiopld hm, looking into video I did not get it .... I.e. I assumed that if we set some status after which it's not possible to cancel order, the button should be "Disabled" in customer apps if such status is already in place. E.g. say if you not allow orders which are packages to be cancelled, customer can't click button for orders where status is packaged already etc. But looking into your video, I see many times button disabled, many times not etc. I am not saying it's wrong how it works now, but I just don't understand it... Maybe when you finish that total feature, we should record another video which clearly demonstrate all that and with NEW orders all the time (i.e. do NOT reuse same order like you do in video, use new orders, change statuses for them, show that if order pass some status customer can't cancel it anymore etc)

@evereq evereq merged commit c0a7c99 into develop Jul 6, 2020
@evereq evereq deleted the feat/#56-admin-disable-canceling-the-order branch July 6, 2020 11:33
@valiopld
Copy link
Contributor Author

valiopld commented Jul 6, 2020

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants