Handle macro returns method name #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbellware
reviewed
Mar 8, 2021
| message_registry.register(message_class) | ||
|
|
||
| handler_method_name | ||
| end |
There was a problem hiding this comment.
To test this, call on a class and capture the return value, and then check the method name.
aaronjensen
force-pushed
the
return-method-name
branch
from
e090309 to
38255e8
Compare
aaronjensen
force-pushed
the
return-method-name
branch
from
38255e8 to
102f4ef
Compare
aaronjensen
force-pushed
the
return-method-name
branch
from
a4ead6c to
857ec3f
Compare
This was referenced Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defanddefine_methodreturn the method name, it's useful for this to as well when used in building higher level abstractions.I wasn't sure about testing this because the test for it hides the usage in a control. I'm up for suggestions on it.