Missing Custom Messages Fields Data Migrating or Installing New Dev Branch

[garthkoyle]

There is missing data in a custom message template, that I expect would have been copied to the new custom template. It will frustrate people if they have to update these fields before using the template especially because they don't know what's supposed to go in those template without doing more research.

• migrate from master to dev OR install dev new
• create a custom message template
• try saving the template as it is presented to you and notice several of the fields are empty and you can't save the template

Here are the specific fields missing for each template:

Payment Received missing fields:

• attendee list
• datetime list
• question list

Refund Issued missing fields:

• attendee list
• datetime list

Registration Approved missing fields:

• To field

Not Approved Registration missing fields:

• question list

Registration Pending Payment missing fields:

• question list

Payment Reminder missing fields:

• attendee list
• datetime list
• question list

Payment Declined missing fields:

• attendee list
• datetime list
• question list

Registration Declined missing fields:

• attendee list
• question list

Registration Cancelled Payment missing fields:

• question list

Payment Failed missing fields:

• attendee list
• datetime list
• question list

Invoice missing fields:

• attendee list
• datetime list
• question list

[tn3rb]

I deleted my db, installed a fresh site, and activated EE on master branch and the following fields were missing (no check - checked off fields were NOT missing)

Payment Received missing fields:

• attendee list
• datetime list
• question list

Refund Issued missing fields:

• attendee list
• datetime list

Registration Approved missing fields:

• To field

Not Approved Registration missing fields:

• question list

Registration Pending Payment missing fields:

• question list

Payment Reminder missing fields:

• attendee list
• datetime list
• question list

Payment Declined missing fields:

• attendee list
• datetime list
• question list

Registration Declined missing fields:

• To field (admin context)
• To field (reg context)
• attendee list
• datetime list
• question list

Registration Cancelled Payment missing fields:

• question list

Payment Failed missing fields:

• attendee list
• datetime list
• question list

Invoice missing fields:

• attendee list
• datetime list
• question list

Considering that those fields are all marked as required the behaviour in dev branch is actually correct, as you should not be able to submit the form is required fields do not have a value. That said, it looks like EVERY field has been marked as required when clearly there is no need for that.

I'm going to remove the required attribute on all of those additional fields

[garthkoyle]

You can merge 3966.

The only remaining issue then is that some of the “to” fields are blank. That’s a bad situation. We don't want a blank "to" field otherwise the messages won't send when expected.

[Pebblo]

@garthkoyle I posted this in slack but just to make sure it isn't buried.

The missing 'To' fields are expected for contexts that are disabled by default

That's how we disabled message contexts before we had the toggle switch on them, so if those are going to be set by default we'll need to make sure the toggle for those same contexts is disabled by default.

[garthkoyle]

@Pebblo Got it. I think it makes sense to have the templates properly set up and turned off if that's what we normally do. cc @tn3rb

[tn3rb]

ok closing this then