Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go-E: set default cache duration #8714

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Go-E: set default cache duration #8714

merged 1 commit into from
Jun 30, 2023

Conversation

thierolm
Copy link
Contributor

@thierolm thierolm commented Jun 30, 2023 •
edited by andig
Loading

Fix #8703

Set cache default duration to 1s to relax go-e from multiple requests.

Refer to discussion #8694

@thierolm thierolm mentioned this pull request Jun 30, 2023
Closed
@andig
Copy link
Member

andig commented Jun 30, 2023

Gute Idee. Ist sichergestellt, dass der Cache bei Schreibzugriffen auch resettet wird?

@andig andig added the enhancement New feature or request label Jun 30, 2023
@thierolm
Copy link
Contributor Author

Oh, dass checke ich noch...

@thierolm
Copy link
Contributor Author

thierolm commented Jun 30, 2023 •
edited
Loading

Hi @andig ,

für den go-e wurde eine extra Api in charger/go-e/api.go gebaut:

image

Enable ruft c.api.Update auf, was auch c.updated setzt, da brauche ich m.E. nichts zu resetten.

Was meinst du?

@andig andig merged commit 1e785b2 into evcc-io:master Jun 30, 2023
@thierolm thierolm deleted the charger/go-e-default-cache branch June 30, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cache parameter to HTTP-based templates
2 participants
@thierolm @andig