Irreführende Warnung wegen zu kleinem Poll Intervall entfernen #7168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irreführende Warnung entfernt
|
eher bei beiden, oder? |
|
Würde mal sagen da liegst Du falsch - cache limitiert immer die Zugriffsrate auf das Fahrzeug API. |
|
Cache wirkt am Ende immer, das stimmt. Die Warnung könnte daher weg. |
|
Wobei man so eine Meldung ggf. für den Parameter vehicles/xy/cache haben möchte. |
|
@MarkusGH kleine Anpassung |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wenn das Poll Intervall am Loadpoint < 1h ist kommt eine Warnung
lp.log.WARN.Printf("poll interval '%v' is lower than %v and may deplete your battery or lead to API misuse. USE AT YOUR OWN RISK.", lp.Soc.Poll.Interval, pollInterval)Die Warnung gehört aber eigentlich bei der Prüfung/Verwendung des Parameters vehicles/xy/cache ausgegeben, denn dort wird letztlich die Frequenz der API Zugriffe limitiert.