Better vehicle status messages (delays, timer) #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ich fürchte diese Nachrichten werden zu deutlich mehr Anwenderfragen führen. Andererseits ist Feedback der beste Weg, bisher verstecktes und vllt. nicht perfektes Verhalten aufzudecken und an die Oberfläche zu zerren. @naltatis rein damit? |
andig
reviewed
Mar 18, 2023
Ja, das war die Idee. Ich wollte erstmal kein Verhalten ändern. Wenn wir feststellen, dass wir das Verhalten verbessern können/sollten bin ich nicht böse drum wenn dieser Code hier später überflüssig wird :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose guard/contactor timer in UI to explain why charging has not started yet. This can occure if the pv enable timer is configured smaller than the contactor delay. This behavior can also be observed in the demo.yaml.
I decided to present this status in a neutral way ("Starting in 1:20m...") to avoid explaining the concept of fast switching protection to the UI.
Possible next step: The current situation is not perfect from a users perspective because the user might first see the pv enable timer (e.g. 2m). When it's done the rest of the guard timer (e.g. 3m
guard delay - pv delay) will appear. Ideally the pv enable timer exposed to the ui should also include the guard delay if it exists and is larger. But this would be a bigger change. Therefore I opted to start with exposing the guard timer as a first step. This is an improvement to the current situation.fixes #6720