Tariffs: add units #5718
Merged
Tariffs: add units #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naltatis
reviewed
Jan 8, 2023
|
Sieht gut aus. Was wir jetzt allerdings haben ist das Potential, dass wir Währungen mischen. Für die Ersparnis verrechnen wir ja bspw. FeedIn und Grid miteinander. Das war der Grund warum wir die Currency bei Tariffs damals direkt nach oben gezogen haben. Währungsumrechnung würde ich bei uns out-of-scope sehen. In der Praxis ist das vermutlich kein Problem, aber wir könnten noch nen Warnung einbauen wenn bspw. die Tibber Währung nicht mit der konfigurierten Feed-In Währung übereinstimmt. |
|
Gute Idee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@naltatis wenn das gemerged ist dann kommen in #5649 noch die Einheiten dazu. Diesen hier also zuerst.