Add dump --cfg command and cleanup flags #4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sieht erstmal gut aus, kann jetzt aber leider zwei Wochen selbst nicht testen da ich mal ohne 💻 in Urlaub bin. |
panzerdev
reviewed
Oct 4, 2022
|
|
||
| rootCmd.PersistentFlags().DurationP("interval", "i", 10*time.Second, "Update interval") |
There was a problem hiding this comment.
Guten Morgen,
habe gerade den latest master bei mir deployed und diese panic bekommen
evcc_1 | goroutine 160 [running]:
evcc_1 | time.NewTicker(0xa5de22?)
evcc_1 | /usr/local/go/src/time/tick.go:24 +0x10f
evcc_1 | github.com/evcc-io/evcc/core.(*Site).Run(0xc0000bc900, 0xc0006fc060, 0x0)
evcc_1 | /build/core/site.go:540 +0x105
evcc_1 | github.com/evcc-io/evcc/cmd.runRoot.func1()
evcc_1 | /build/cmd/root.go:288 +0x31
evcc_1 | created by github.com/evcc-io/evcc/cmd.runRoot
evcc_1 | /build/cmd/root.go:287 +0x134c
Habe den in der config das interval: 10s gesetzt und alles geht wieder. Ich würde sagen der default ist mit diesem cleanup verloren gegangen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4659 (comment)