Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle startup errors #4383

Merged
merged 30 commits into from
Sep 22, 2022
Merged

Gracefully handle startup errors #4383

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
46ee58e
Gracefully handle startup errors
andig Sep 11, 2022
bafe41c
wip
andig Sep 11, 2022
237b8d8
wip
andig Sep 11, 2022
cc71a8d
Remove more fatals
andig Sep 11, 2022
fb2aae6
Better error message
andig Sep 11, 2022
aedd4fb
wip
andig Sep 11, 2022
811a75e
wip
andig Sep 11, 2022
e1b5d70
Unwrap errors
andig Sep 11, 2022
0e82a7a
Expose to ui
andig Sep 11, 2022
1fc9195
Add config
andig Sep 12, 2022
8deac57
fix fatal undefined error
naltatis Sep 17, 2022
00073f0
Handle file-related errors
andig Sep 17, 2022
01b2cd8
wip
andig Sep 18, 2022
0a9e673
wip
andig Sep 18, 2022
273cff9
wip
andig Sep 18, 2022
a487224
Add config file and yaml error line
andig Sep 18, 2022
cf35a1b
wip
andig Sep 18, 2022
6ddb244
Better secrets
andig Sep 18, 2022
d1b5b39
wip
andig Sep 18, 2022
8633690
wip
andig Sep 18, 2022
5f439f2
Improve handling config file not found
andig Sep 19, 2022
27ce0d3
prettier startup error page
naltatis Sep 19, 2022
6911636
prettier startup error page; restart button; remove health check polling
naltatis Sep 20, 2022
7af605e
Fix rebase
andig Sep 21, 2022
1231fe5
Fix test
andig Sep 21, 2022
e7a4561
Add shutdown handler
andig Sep 21, 2022
9bc0011
Check secrets for : to make match more specific
andig Sep 21, 2022
e70bcae
translations; restart message in log; removed autorestart; disabled r…
naltatis Sep 22, 2022
ae4c98c
autorestart every 5m
naltatis Sep 22, 2022
8f4342b
wip
andig Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip
  • Loading branch information
@andig
andig committed Sep 21, 2022
commit aedd4fb394e6664002daaffd4f0bc161b123394e
27 changes: 13 additions & 14 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,19 @@ func run(cmd *cobra.Command, args []string) {

// allow web access for vehicles
cp.webControl(conf.Network, httpd.Router(), valueChan)
} else {
// delayed reboot on error
const reboot = time.Minute

log.FATAL.Println(err)
log.FATAL.Printf("will attempt restart in: %v", reboot)

publish("fatal", err)

time.AfterFunc(reboot, func() {
os.Exit(1)
})

}

stopC := make(chan struct{})
Expand All @@ -277,20 +290,6 @@ func run(cmd *cobra.Command, args []string) {
close(siteC)
}()

// delayed reboot on error
if err != nil {
const reboot = time.Minute

log.FATAL.Println(err)
log.FATAL.Printf("will attempt restart in: %v", reboot)

publish("fatal", err)

time.AfterFunc(reboot, func() {
os.Exit(1)
})
}

// uds health check listener
go server.HealthListener(site, siteC)

Expand Down