Skip to content

Conversation

@jmerifjKriwe
Copy link

@jmerifjKriwe jmerifjKriwe commented Nov 16, 2025

Add template for ora2mqtt.
Will add support for GWM Ora (400) cars via ora2mqtt.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig added the vehicles Specific vehicle support label Nov 17, 2025
@andig
Copy link
Member

andig commented Nov 18, 2025

Pls format and add description what this template is even for.

@andig andig marked this pull request as draft November 18, 2025 08:25
@jmerifjKriwe
Copy link
Author

I'dont get it. What do I need to format?
I just took another 2mqtt-template and changed the values to make it run with ora2mqtt.
So I need a hint what I should format in another way :-)

@andig
Copy link
Member

andig commented Nov 19, 2025

It seems the indents are odd?

@jmerifjKriwe
Copy link
Author

It seems the indents are odd?

Can you give me an example? If I take a look at https://github.com/evcc-io/evcc/pull/25350/files all indents seems to be fine.
Sorry that I need help for such a simple PR :-/

Fixed wrong intent
@jmerifjKriwe jmerifjKriwe marked this pull request as ready for review December 1, 2025 08:15
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig
Copy link
Member

andig commented Dec 4, 2025

According to

Leider besitze ich keinen Ora Funky Cat mehr, daher wird die Entwicklung hier nicht mehr weitergehen. Wenn das jemand übernehmen möchte - immer gern.

Development has stopped. Since this can still be integrated using custom device, we shouldn't merge. Sorry.

@andig andig closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vehicles Specific vehicle support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants