Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction/totalenergy for tasmota and tplink charger #2484

Merged
merged 6 commits into from
Feb 4, 2022

Conversation

thierolm
Copy link
Contributor

@thierolm thierolm commented Feb 3, 2022

Refer to #2483

@thierolm
Copy link
Contributor Author

thierolm commented Feb 3, 2022

Tasmota ist getestet:

wallbox5
--------
Power:         0W
Energy:        88.7kWh
Charge status: B
Enabled:       false

image

charger/tasmota.go Outdated Show resolved Hide resolved
@andig
Copy link
Member

andig commented Feb 3, 2022

Wie haben wir es jetzt geschafft hier Kommentare aus einem anderen PR rein zu bekommen? Waiting for tplink?

@thierolm
Copy link
Contributor Author

thierolm commented Feb 3, 2022

Keine Ahnung, wie die Kommentare reingekommen sind. Ich habe den PR über VSSCode erzeugt.
Ist bisher immer ohne Probleme gelaufen.

@thierolm
Copy link
Contributor Author

thierolm commented Feb 3, 2022

Tp-Link ist geändert. Testen kann ich leider nicht, da keine TP-Link Dose mehr habe. Allerdings habe in der tasmota/types_test.go Test-Jsons gespeichert. ==> Sollte passen.

@andig andig merged commit 58b6e70 into evcc-io:master Feb 4, 2022
@andig
Copy link
Member

andig commented Feb 4, 2022

Vielen Dank!!!

@thierolm thierolm deleted the correction/totalenergy branch February 26, 2022 22:42
dontbyte pushed a commit to dontbyte/evcc that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants