Skip to content

Conversation

andig
Copy link
Member

@andig andig commented Oct 20, 2025

Follow-up to #24082. May be reverted (and limited to MPC) when #24074 is implemented.

@andig andig added the enhancement New feature or request label Oct 20, 2025
@andig andig requested a review from premultiply October 20, 2025 12:07
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig
Copy link
Member Author

andig commented Oct 20, 2025

@premultiply even worse: the LPC use case here is wrong imho. For dimming you'll need energy guard, not controllable system. See #24592 for clarity.

@andig andig merged commit 3572378 into master Oct 20, 2025
7 checks passed
@andig andig deleted the fix/lpc branch October 20, 2025 13:52
andig added a commit that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant