-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Bender: add semp-based phase switching #24377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bender: add semp-based phase switching #24377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @mfuchs1984, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Thanks for the feedback, will probably work on this again on Friday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: andig <cpuidle@gmail.com>
Co-authored-by: andig <cpuidle@gmail.com>
Co-authored-by: andig <cpuidle@gmail.com>
I updated it by
|
Will do some more testing after the latest changes. |
Based on #23919, this adds phase switching to the existing Bender template. Replaces #24170.
Bender based chargers currently don't allow phase switching through Modbus, but since firmware version 5.33, through semp.
How it works:
230 V * 6 A
), it won't switch phases when the voltage is 231 V, when sending something higher that the maximum with current voltage and 16 A, it also won't switch. Since the grid voltage is 230V +- 10%, depending on the voltage, the power range for 1p can be within207 V * 6 A = 1242 W
to253 V * 16 A = 4048 W
and for 3p207 V * 6 A * 3 = 3726
to253 V * 16 A * 3 = 12144
.253 V * 6 A
) for 1p, since it it can be reached with both, 207 V and 253 V in case of 1p and never with 3p207 V *16 A * 3
) for 3p, since it it can be reached with both, 207 V and 253 V in case of 3p and never with 1p230*3*16
) and a voltage higher than 230 V, it won't reach 16 A, just 15 (coarse current). But when it comes to maximum current, it is super simple: we can just send something very high. I chose 0xffff, so it will always allow control through modbus throughout the full 6 - 16 A range. Note that this will not trigger switching from 1p to 3p, since it is guaranteed to be outside of the real 3p power range. This is done through the heartbeat, which also ensures no SEMP timeout will occur on the charger side.When SEMP is activated on the charger, it will auto detect and check for phase switching support (which has to be enabled separately). When no phase switching is enabled, the user is informed through a warning. Otherwise, it logs support as info and decorates api.PhaseSwitcher and api.PhaseGetter.
Already existing logic for phase switching through Modbus on the new Mennekes chargers remains untouched. Also, whrn SEMP is not enabled, it will behave exactly as before, so this is an optional feature.
Compared to the new SEMP charger introduced with #23919, it offers more accurate measurements, proven stable Modbus control, RFID (including vehicle MAC, which is an awesome Bender feature) and a proper PhaseGetter.
@premultiply in case people report issues with phase switching with your new SEMP charger, it might also be related to selecting the correct powers, so you might try to use what I used here for 1p and 3p in this case.
I tested this for over a week now without issues on my Spelsberg Smart Pro. Would love to see it in the nightly to collect more data from other Bender users.