Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ostrom #16354
base: master
Are you sure you want to change the base?
Add Ostrom #16354
Changes from 25 commits
3fcdc5f
8ae3ddc
0ab6018
3232dcb
8365d4e
294357b
0e69d9d
bc999ac
ccc644f
c35535e
9df719f
04ec7a2
919456c
21f02b6
14b240b
3921912
9c2c1ee
08d3cbe
60c2a7c
89bffac
edf5629
a937584
67a9016
6a48b43
32471e1
f3c6d97
b729ef7
a68c41c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wozu braucht es val.Marketprice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Der Gesamtpreis ergibt sich als "Marketprice+AdditionalCost", siehe
rate()
. Da steht also der Preis drin. Ich wollte so weit es geht dieselben Datenstrukturen und Funktionen für statische und dynamische Preise verwenden, daher wird hier auch für statische Preise einostrom.ForcastInfo
verwendet, um sorate()
nutzen zu können.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wozu braucht es val.StartTimestamp? Das sollte eine lokale Variable sein.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das wird in
rate()
zur Berechnung von start-und Endzeit verwendet. Ansonsten, siehe mein Kommentar zu "Marketprice"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das sieht falsch aus. Fehler zurück geben?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das würde die Run Funktion ja beenden. Mein Gedanke war, dass es diesmal einen Fehler gegeben haben kann, dass aber den nächste Aufruf vielleicht funktioniert.