Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modbus: validate protocol #15912

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Modbus: validate protocol #15912

merged 4 commits into from
Sep 5, 2024

Conversation

andig
Copy link
Member

@andig andig commented Sep 5, 2024

Fix #15833

@andig andig added the enhancement New feature or request label Sep 5, 2024
@andig andig merged commit 333bcfa into master Sep 5, 2024
6 checks passed
@andig andig deleted the fix/modbus-proto branch September 5, 2024 18:07
@kblees

This comment was marked as off-topic.

@andig
Copy link
Member Author

andig commented Sep 11, 2024

Welche neue Fehlermeldung? Was hat das mit diesem PR zu tun?

@kblees
Copy link

kblees commented Sep 11, 2024

Welche neue Fehlermeldung?

Diese: connection already registered with different protocol: %s, die stammt doch aus diesem PR, oder?

Die kommt bei mir mit folgender Config (nur der relevante Teil):

modbusproxy:
  - port: 5200
    uri: 192.168.1.13:502
chargers:
  - name: wallbox
    modbus: rs485tcpip
    host: 192.168.1.13
    port: 502

Workaround ist, entweder modbusproxy rauszunehmen oder die Wallbox auf Modbus-TCP Protokoll umzustellen.

Ich hab' nicht näher in den Code geschaut, aber vermutlich registriert der Modbusproxy die Wallbox-Adresse (192.168.1.13:502) mit Modbus-TCP-Protokoll, was dann den Fehler auslöst. Stattdessen müsste Modbusproxy denke ich seine eigene Adresse (<evcc-ip>:5200) registrieren.

@andig
Copy link
Member Author

andig commented Sep 15, 2024

Das sieht aus wie #16086 und sollte behoben sein.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modbus: validate connection type per physical connection
2 participants