Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[wattpilot]: logging abilities #15894

Merged
merged 4 commits into from
Sep 4, 2024
Merged

fix[wattpilot]: logging abilities #15894

merged 4 commits into from
Sep 4, 2024

Conversation

mabunixda
Copy link
Contributor

Added logging on trace level to wattpilot charger

@mabunixda
fix: logging abilities
d1a143c
@mabunixda
Merge branch 'master' into fix/wattpilot-logging
fffdc78 
* master:
  Fix status reason  ot updated (evcc-io#15873)
  Translations update from Hosted Weblate (evcc-io#15723)
  chore: upgrade libraries
  Fronius Wattpilot: re-add (evcc-io#15843)
  chore: upgrade dependencies
  Ocpp: do not return error on setup (evcc-io#15853)
  EEbus: only disable recommendations if available (evcc-io#15829)
@mabunixda mabunixda marked this pull request as draft September 4, 2024 07:55
@mabunixda
Copy link
Contributor Author

@andig Irgendwie passt aber die Implementierung nicht

  • die Logs tauchen sofort auf
  • der Wattpilot ist nicht als Bereich in der Logview auswählbar

ich finde aber den Fehler nicht - ich hab durch die anderen Charger durchgeschaut und da sieht der Code ja ähnlich aus

@andig
Copy link
Member

andig commented Sep 4, 2024

Kann ich nix zu sagen- hier passiert ja nix. These: du schreibst irgendwo anders rein?

@mabunixda
Copy link
Contributor Author

Kann ich nix zu sagen- hier passiert ja nix. These: du schreibst irgendwo anders rein?

Der evcc Logger wird dann intern weiterbenutzt mittels

# logger = log.TRACE
w.logger.Out = logger.Writer()

Und bei mir in der API Implementierung ist w.logger ein logrus.logger

Dann kommt als Output momentan sowas raus - sprich der evcc Logger verliert hier an Infos / Formatierung etc.

time="2024-09-04T14:52:45+02:00" level=trace msg="Delta status update" wattpilot=10.2.0.12
time="2024-09-04T14:52:45+02:00" level=trace msg="Enter Data-status updates" wattpilot=10.2.0.12
time="2024-09-04T14:52:45+02:00" level=trace msg="Data-status gets updates #12" wattpilot=10.2.0.12
time="2024-09-04T14:52:45+02:00" level=trace msg="done deltaStatus" wattpilot=10.2.0.12
time="2024-09-04T14:52:46+02:00" level=trace msg="receiving deltaStatus" wattpilot=10.2.0.12
time="2024-09-04T14:52:46+02:00" level=trace msg="Delta status update" wattpilot=10.2.0.12
time="2024-09-04T14:52:46+02:00" level=trace msg="Enter Data-status updates" wattpilot=10.2.0.12
time="2024-09-04T14:52:46+02:00" level=trace msg="Data-status gets updates #11" wattpilot=10.2.0.12
time="2024-09-04T14:52:46+02:00" level=trace msg="done deltaStatus" wattpilot=10.2.0.12
time="2024-09-04T14:52:47+02:00" level=trace msg="receiving deltaStatus" wattpilot=10.2.0.12
time="2024-09-04T14:52:47+02:00" level=trace msg="Delta status update" wattpilot=10.2.0.12
time="2024-09-04T14:52:47+02:00" level=trace msg="Enter Data-status updates" wattpilot=10.2.0.12
time="2024-09-04T14:52:47+02:00" level=trace msg="Data-status gets updates #6" wattpilot=10.2.0.12
time="2024-09-04T14:52:47+02:00" level=trace msg="done deltaStatus" wattpilot=10.2.0.12
time="2024-09-04T14:52:48+02:00" level=trace msg="receiving deltaStatus" wattpilot=10.2.0.12
time="2024-09-04T14:52:48+02:00" level=trace msg="Delta status update" wattpilot=10.2.0.12
time="2024-09-04T14:52:48+02:00" level=trace msg="Enter Data-status updates" wattpilot=10.2.0.12
time="2024-09-04T14:52:48+02:00" level=trace msg="Data-status gets updates #7" wattpilot=10.2.0.12
time="2024-09-04T14:52:48+02:00" level=trace msg="done deltaStatus" wattpilot=10.2.0.12

@andig
Copy link
Member

andig commented Sep 4, 2024

Du musst direkt den Logger nutzen, nicht seinen Writer.

andig
andig requested changes Sep 4, 2024
View reviewed changes
charger/fronius-wattpilot.go Show resolved Hide resolved
charger/fronius-wattpilot.go Show resolved Hide resolved
charger/fronius-wattpilot.go Outdated Show resolved Hide resolved
@mabunixda
fix: wattpilot logging with delegate function to evcc
07f4b14 
Signed-off-by: Martin Buchleitner <mbuchleitner@infralovers.com>
@mabunixda mabunixda marked this pull request as ready for review September 4, 2024 15:03
@mabunixda
Copy link
Contributor Author

Du musst direkt den Logger nutzen, nicht seinen Writer.

Ja hab's nun anders gelöst, sodass die loglevel auch korrekt ankommen

@mabunixda mabunixda requested a review from andig September 4, 2024 15:09
@mabunixda
fix: update log level mapping
f1e13f8 
Signed-off-by: Martin Buchleitner <mbuchleitner@infralovers.com>
@mabunixda mabunixda requested a review from andig September 4, 2024 16:12
@andig andig merged commit 06e2b16 into evcc-io:master Sep 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig Awaiting requested review from andig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabunixda @andig