Remove guard timer but keep charger sync logic #12084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compile errors and clean up
Fix compile errors
Fixed setEnabled logic
Fix tests
Remove guardDuration
Remove unneeded import
Fix comment
GrimmiMeloni
reviewed
Feb 5, 2024
andig
reviewed
Feb 6, 2024
Co-authored-by: andig <cpuidle@gmx.de>
Removed redundant logic and fixed naming
Fix compile error
Improved comments
|
Habe nochmals die Logik vereinfacht, da war noch eine redundante Verzweigung. |
Re-added GuardDuration
Deprecated GuardDuration
Fixed enabledChanged
andig
reviewed
Feb 8, 2024
Co-authored-by: andig <cpuidle@gmx.de>
Simplified logic, fixed typo
andig
reviewed
Feb 8, 2024
|
Wo stehen wir hier denn jetzt? Ist das gesamte Thema mit #11878 bereits erledigt? Wenn nein, was ist jetzt hier noch offen? Braucht Ihr noch Unterstützung? |
|
@naltatis muss ran 😎 |
|
@andig done. Fehlt nur noch der Konflikt beim Test. Da ist mir aber nicht klar was da passiert ist. |
|
Schöner PR- schauen wir mal, wohin das führt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11953 (comment), replaces #12053
TODO
guardtimerfrom ui @naltatis