Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace current precendence with min/max logic #11311

Merged
merged 5 commits into from
Dec 30, 2023
Merged

Replace current precendence with min/max logic #11311

merged 5 commits into from
Dec 30, 2023

Conversation

andig
Copy link
Member

@andig andig commented Dec 28, 2023 •
edited
Loading

Fix #11280

TODO

  • check UI min/max dialog
  • allow charger to override loadpoint minCurrent (EEbus/ISO)
  • add tests

Out of scope

  • limit UI dialog to loadpoint min/max @naltatis

@andig andig added the enhancement New feature or request label Dec 28, 2023
@premultiply premultiply changed the title Replace current precendence with mix/max logic Replace current precendence with min/max logic Dec 28, 2023
GrimmiMeloni
GrimmiMeloni approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@GrimmiMeloni GrimmiMeloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VolkerK62 VolkerK62 mentioned this pull request Dec 30, 2023
Closed
@andig andig force-pushed the feature/current-precedence branch from 2448e96 to 69c6cda Compare December 30, 2023 16:28
@andig andig merged commit cf59742 into master Dec 30, 2023
6 checks passed
@andig andig deleted the feature/current-precedence branch December 30, 2023 18:06
@docolli docolli mentioned this pull request Jan 12, 2024
Closed
@andig andig mentioned this pull request Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrimmiMeloni GrimmiMeloni GrimmiMeloni approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In mode "now" evcc uses only maxcurrent from vehicle, no longer from loadpoint
2 participants
@andig @GrimmiMeloni