Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sungrow: add battery control #10833

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Sungrow: add battery control #10833

merged 7 commits into from
Nov 21, 2023

Conversation

andig
Copy link
Member

@andig andig commented Nov 19, 2023 •
edited
Loading

Refs #10379

Depends on #10808

  • fix const

@andig andig added enhancement New feature or request devices Specific device support labels Nov 19, 2023
@andig andig marked this pull request as draft November 19, 2023 11:56
@andig andig force-pushed the feature/sungrow-battery-control branch from cf67374 to eb6e84b Compare November 20, 2023 10:17
@andig andig marked this pull request as ready for review November 20, 2023 10:18
@andig andig force-pushed the feature/sungrow-battery-control branch from eb6e84b to 5d730b2 Compare November 20, 2023 10:25
@naltatis
Copy link
Member

Works like expected. Danke @andig!

@andig
Copy link
Member Author

andig commented Nov 20, 2023

Nice! Gar nicht schlecht so ungetestet. Waiting for SolarEdge…

@naltatis
Copy link
Member

naltatis commented Nov 20, 2023 •
edited
Loading

Featurewunsch: Batteriemodus beim ordnungsgemäßen Runterfahren von evcc wieder in "normal" zurückschalten. Musste den Branch wieder reaktivieren und schnell-laden starten stoppen um in einen normalen Betriebsmodus zu kommen.

@premultiply
Copy link
Member

Guter Punkt!
Das ist bei den Lösungen mit Timeout natürlich einfacher. Da reicht dann einfaches Aussitzen um wieder in den Normalmodus zu gelangen.

@andig andig force-pushed the feature/sungrow-battery-control branch from 5de25f1 to de5cb7e Compare November 21, 2023 09:31
@andig andig merged commit bf36704 into master Nov 21, 2023
6 checks passed
@andig andig deleted the feature/sungrow-battery-control branch November 21, 2023 09:47
@andig
Copy link
Member Author

andig commented Nov 21, 2023

Featurewunsch: Batteriemodus beim ordnungsgemäßen Runterfahren von evcc wieder in "normal" zurückschalten. Musste den Branch wieder reaktivieren und schnell-laden starten stoppen um in einen normalen Betriebsmodus zu kommen.

Ist in #10815 ergänzt. So als kleines Incentive ;)

@andig andig added this to the Battery Control milestone Dec 6, 2023
@danmel42
Copy link

danmel42 commented Dec 10, 2023 •
edited
Loading

Jungs, letzte Nacht gab es endlich mal eine Konstellation wo ich das testen konnte.

Works like a charm!

Ganz ganz vielen Dank dafür!
Ich benutze jetzt evcc seit gut einem Jahr. Am Anfang war das eher so experimentell, auch weil ich selber meine Lernkurve hatte.
Inzwischen verrichtet evcc lautlos seinen Dienst (wenn ich nicht gerade mal was testen muss) und ist zum wichtigen Baustein hier ein meinem Setup geworden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
devices Specific device support enhancement New feature or request
Projects
None yet
Milestone
Battery Control
Development

Successfully merging this pull request may close these issues.
4 participants
@andig @naltatis @premultiply @danmel42