Plugins: allow returning errors when instantiating plugin getter/setter #10778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerne, aber wenn Du ein schnelles Resultat möchtest, dann solltest Du bitte einen Nightly anstoßen - ich bin ab morgen 8 Tage AFK. |
andig
changed the title
andig
force-pushed
the
feature/provider-errors
branch
from
70f068b to
508f017
Compare
andig
force-pushed
the
feature/provider-errors
branch
from
508f017 to
da1aed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10775
This PR accepts the fact that not all instantiation errors happen when creating the plugin, but sometimes only when creating the specific getter or setter. Hence, creating the accessor should also be able to return errors. Doesn't make the code nicer but handles more error cases in a controlled way.
@MarkusGH könntest Du das mal bitte testen?