Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Missing translation when failed startup #14694

Closed
zigad opened this issue Jul 4, 2024 · 0 comments
Closed

UI: Missing translation when failed startup #14694

zigad opened this issue Jul 4, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request ux User experience/ interface

Comments

@zigad
Copy link
Contributor

zigad commented Jul 4, 2024

Describe the bug

I noticed there is a missing translation when configuration is wrong and the program fails so I have added the missing translation of the text "Error during startup. Check your configuration and restart.".

We would probably need to update each error to also be translated but since there are many error we could do it later.

I have tested this locally and it works as expected.

1st line is now included in en.toml, second line of error should probably be also translatable in future.

Screenshot 2024-07-04 at 17 51 03 Screenshot 2024-07-04 at 17 51 13

I will create a pull request for you to review it and link it here.

Steps to reproduce

  1. enter wrong configuration
    2.see the error

Configuration details

N/A

Log details

N/A

What type of operating system are you running?

Docker container

Version

N/A

zigad added a commit to zigad/evcc that referenced this issue Jul 4, 2024
@andig andig added the enhancement New feature or request label Jul 4, 2024
@andig andig added the ux User experience/ interface label Jul 4, 2024
naltatis added a commit that referenced this issue Jul 5, 2024
* Update: Add new translation #14694

* toml sorting, add de

---------

Co-authored-by: Michael Geers <michael@geers.tv>
@naltatis naltatis closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux User experience/ interface
Projects
None yet
Development

No branches or pull requests

3 participants