F-Droid build failed

[linsui]

Recently expo added non-free deps to expo-dev-launcher. expo/expo@5cbd0d4. IIUC, expo-dev-client should only be used for development. Could you please exclude it from release build? Thanks!

[Maschga]

@linsui Thank you very much for notifying us.
A new release with a fix has been released: https://github.com/evcc-io/app/releases/tag/1.1.1

[licaon-kter]

are you sure you build from a clean terete checked out at the tagged 7b4ede3 ?

The diff is huge: https://gitlab.com/fdroid/fdroiddata/-/jobs/11722640108#L4100

[Maschga]

Thank you for your response.
I assume the fix did not work.

[Maschga]

Seems like autolinking had a bug which is already fixed: expo/expo#40014
However, this fix has not yet been released: https://github.com/expo/expo/blob/main/packages/expo-modules-autolinking/CHANGELOG.md#unpublished

[linsui]

How about just removing expo-dev-client in scripts/fdroid/excludeNonfreeDependencies.ts?

[Maschga]

Your message is a bit ambiguous sicne we're talking about removing/excluding packages. :D

• If you mean this: expoAutolinking.exclude = ["expo-dev-client"]
  This way, the build succeeds, but expo-dev-launcher is linked. I don't know if this is okay for F-Droid when removing expo-dev-client.

• If you mean this: expoAutolinking.exclude = ["expo-dev-launcher"]
  This way the build fails. expo-dev-client is somehow connected to expo-dev-launcher and needs the expo-dev-launcher package.

[linsui]

I mean you can just run npm remove expo-dev-client before building the github release. :)

[Maschga]

I would rather wait for the release so that I don't have to change the pipeline.

[naltatis]

@Maschga is this still an issue?

[Maschga]

Yes.