Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to be more testable #9

Closed
evaristocuesta opened this issue Dec 13, 2020 · 1 comment
Closed

Refactoring to be more testable #9

evaristocuesta opened this issue Dec 13, 2020 · 1 comment
Assignees
@evaristocuesta
Labels
enhancement New feature or request
Milestone
EspejoAnalysis v1...

Comments

@evaristocuesta
Copy link
Owner

evaristocuesta commented Dec 13, 2020 •
edited
Loading

Inject EsterolesLogic to EsterolesViewModel to be more testable.
Add System.IO.Abstractions to be more testable.
@evaristocuesta evaristocuesta added the enhancement New feature or request label Dec 13, 2020
@evaristocuesta evaristocuesta self-assigned this Dec 13, 2020
@evaristocuesta evaristocuesta added this to the EspejoAnalysis v1.0.8 milestone Dec 13, 2020
@evaristocuesta evaristocuesta changed the title Inject EsterolesLogic to EsterolesViewModel Refactoring to be more testable Dec 25, 2020
evaristocuesta added a commit that referenced this issue Dec 26, 2020
@evaristocuesta
Issue #9: Refactoring to be more testable
3fba7ee
@evaristocuesta
Copy link
Owner Author

evaristocuesta commented Dec 26, 2020 •
edited
Loading

  • Testing project added
  • IEsterolesLogic added to be implemented by EsterolesLogic
  • EsterolesLogic is injected to EsterolesViewModel
  • System.IO.Abstrations added to be more testable
  • MainViewModel use a dictionary with the IAnalysis view models to avoid dependency with SimpleIoc

evaristocuesta added a commit that referenced this issue Dec 26, 2020
@evaristocuesta
Issue #9: Adding more unit tests
5726e81
evaristocuesta added a commit that referenced this issue Dec 27, 2020
@evaristocuesta
Issue #9: Adding more unit tests
3c86961
evaristocuesta added a commit that referenced this issue Dec 28, 2020
@evaristocuesta
Issue #9: Adding more unit tests
16ac537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evaristocuesta evaristocuesta

Labels
enhancement New feature or request
Projects
None yet
Milestone
EspejoAnalysis v1.0.8
Development

No branches or pull requests
1 participant
@evaristocuesta