Skip to content

Minor changes README#Tests. #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2015
Merged

Minor changes README#Tests. #110

merged 2 commits into from
Oct 23, 2015

Conversation

julien-f
Copy link
Collaborator

No description provided.

@LinusU
Copy link
Collaborator

LinusU commented Oct 22, 2015

Is there any upside to using anything else than the python thing? Python is available on OS X and nearly every Linux dist.

Maybe the best would be du include http-server as a devDependencies and add a scripts entry for running it?

@julien-f
Copy link
Collaborator Author

Nope, there is no particular upside in using http-server but I don't know if the SimpleHTTPServer module is available everywhere.

Anyway, it makes sense to me to propose a Node alternative.

@LinusU
Copy link
Collaborator

LinusU commented Oct 22, 2015

SimpleHTTPServer is built in to the standard python library so that should always be available. I also like the idea of promoting a Node.js alternative, but I don't like listing more than one choice. That pushes the decision on to the end user which increases cognitive load. Also, the python route is a straight forward command which have no downside other than being python rather than node.js. http-server in this case is a link where you need to read up on how to use it.

What do you think about adding a scripts entry in the package.json?

@julien-f
Copy link
Collaborator Author

Yep, that seems to be the best way.

@LinusU
Copy link
Collaborator

LinusU commented Oct 22, 2015

Fantastic, I will try to test this tonight (Swedish time) and then merge!

@julien-f
Copy link
Collaborator Author

@LinusU I intend to make a release ASAP, any last comments on this PR?

@LinusU
Copy link
Collaborator

LinusU commented Oct 23, 2015

LGTM 👍

julien-f added a commit that referenced this pull request Oct 23, 2015
@julien-f julien-f merged commit aeec105 into master Oct 23, 2015
@julien-f julien-f deleted the julien-f-improve-readme-tests branch October 23, 2015 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants