-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow wildcards for externals #406
Comments
I did similar approach but I had to move all the svgs and css to specific folder which I could exclude. |
I can't have everything in a single folder unfortunately. My current approach is actually to run esbuild twice:
This is still way faster and more accurate than any npm library I tried to get hold of the file dependency tree of my project... |
Does a wildcard regex as done here #420 (comment) resolve this? This is what I've been doing to have wildcard externals |
FWIW you can do this as a plugin pretty easily. The plugin API is documented here: https://esbuild.github.io/plugins/. |
Thanks, I'll close this. Been too busy to get into the plugins but now that they're there this will no longer be needed |
The latest release allows you to use a single |
I use Webpack as a second pass to handle things such as turning SVGs into React components, importing AngularJS HTML templates and simply placing the assets exactly where I want them. In order to do that right now I have a script that builds a list of all the files that should be treated as external by esbuild because it seems to only accept absolute paths. This adds to the overhead of running Webpack...
Would it be possible to support wildcards (or even regular expressions) to specify externals?
The text was updated successfully, but these errors were encountered: