Use ViewTreeLifecycleOwner to reliably get the lifecycle owner for databinding. #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evant
force-pushed
the
viewtreelifecycleowner
branch
2 times, most recently
from
2d18305 to
1bb19c8
Compare
evant
force-pushed
the
viewtreelifecycleowner
branch
from
1bb19c8 to
a7a2050
Compare
|
When is this commit being merged? |
Owner
Author
|
Good question! The reason is it's been sitting here is I had hoped data binding would start using this method internally itself which would simplify the implementation. Haven't checked that that's the case or is on the roadmap. |
|
Could you consider merging, and in a later stage re-evaluate the need for it? |
|
Could you consider merging, and in a later stage re-evaluate the need for it? @evant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.