Skip to content

Conversation

abiskop
Copy link
Contributor

@abiskop abiskop commented Jun 9, 2015

fixes #7

@evanshortiss
Copy link
Owner

This looks great @abiskop. I've been busy with work the last few days but should get around to merging this tonight.

@evanshortiss
Copy link
Owner

@abiskop could you possibly update the README with information on the newly added features?

@abiskop
Copy link
Contributor Author

abiskop commented Jun 17, 2015

Sure! Will do that tomorrow!

EDIT: Did not get to it so far due to stuff@work, but hopefully during the next days.

@evanshortiss
Copy link
Owner

Thanks for the update @abiskop. I can relate :)

@abiskop
Copy link
Contributor Author

abiskop commented Jun 23, 2015

Alright, README update done!

@evanshortiss
Copy link
Owner

This is an awesome PR thanks @abiskop! I'll get it published to npm within 24 hours.

👏

evanshortiss added a commit that referenced this pull request Jun 24, 2015
Add support for topics. Update to newer AWS SDK.
@evanshortiss evanshortiss merged commit 108ee2d into evanshortiss:master Jun 24, 2015
@evanshortiss
Copy link
Owner

@abiskop published to npm registry as version 1.2.0

@abiskop
Copy link
Contributor Author

abiskop commented Jun 26, 2015

Great, thanks! I might also add the remaining topic-/subscription-related methods like "getTopicAttributes" and stuff at some point; I just didn't really need it at this point, that's why I skipped it during the first iteration.
Also, I realized that in many cases, one does not actually need to know the platform(Application(Arn)), e.g. for creating topics, subscribing users etc.; however, it is strictly required that it is passed into the constructor when creating an instance of the interface. We might consider changing the API here at some point so that the platform has to be passed only into methods that actually need it...

@evanshortiss
Copy link
Owner

Add things only when we need them. The evolutionary development process ;)

@race
Copy link
Contributor

race commented Jun 26, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for topics?
3 participants