Skip to content

fix: types change for new express querystring types #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanshortiss merged 2 commits into from
Jul 23, 2020
Merged

fix: types change for new express querystring types #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df3d46
fix: address new qs typings in express types
evanshortiss Jul 15, 2020
11ddc7a
4.0.4-beta.0
evanshortiss Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion express-joi-validation.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as Joi from '@hapi/joi'
import * as express from 'express'
import { IncomingHttpHeaders } from 'http'
import { ParsedQs } from 'qs'

/**
* Creates an instance of this module that can be used to generate middleware
Expand Down Expand Up @@ -43,7 +44,7 @@ export type ValidatedRequestSchema = Record<ContainerTypes, any>
export interface ValidatedRequest<T extends ValidatedRequestSchema>
extends express.Request {
body: T[ContainerTypes.Body]
query: T[ContainerTypes.Query]
query: T[ContainerTypes.Query] & ParsedQs
headers: T[ContainerTypes.Headers]
params: T[ContainerTypes.Params]
}
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "express-joi-validation",
"version": "4.0.3",
"version": "4.0.4-beta.0",
"description": "validate express application inputs and parameters using joi",
"main": "express-joi-validation.js",
"scripts": {
Expand Down Expand Up @@ -34,6 +34,7 @@
"@types/express-formidable": "~1.0.4",
"@types/hapi__joi": "~16.0.3",
"@types/node": "~10.14.18",
"@types/qs": "~6.9.3",
"body-parser": "~1.18.3",
"chai": "~3.5.0",
"clear-require": "~2.0.0",
Expand All @@ -50,6 +51,7 @@
"nyc": "~14.1.1",
"prettier": "~1.14.3",
"proxyquire": "~1.7.11",
"qs": "~6.9.4",
"sinon": "~1.17.7",
"supertest": "~3.0.0",
"typescript": "~3.5.2"
Expand Down