Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to declare empty directory #86

Merged
merged 6 commits into from
Nov 18, 2021

Conversation

devgs
Copy link
Contributor

@devgs devgs commented Nov 17, 2021

We had a need to be able to create archives that contain empty directories. It was not possible with existing tools, since directories are implicitly declared when the file paths contain their names. For this reason I've added a special marker @directory that is recognized in place of an url. So, as per example, you can now declare them:

1034ab38 428    /foo.txt   My Document1.txt
83e8110b 100339 /bar.txt   My Other Document1.txt
0        0      @directory My empty directory

@evanmiller
Copy link
Owner

Can you please add this feature to the test suite to ensure it doesn't break in the future? See the t/ directory.

@devgs
Copy link
Contributor Author

devgs commented Nov 18, 2021

@evanmiller Done. Added test cases to cover empty directories. Excuse my force pushes, didn't want to spam the commit history because of small mistakes.

@evanmiller
Copy link
Owner

@devgs Thanks!

@evanmiller evanmiller merged commit 51cf45d into evanmiller:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants