Fix for crc calculation on upstream subrequest #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious - I haven't worked on many C libraries/projects - but is it common for code changes like those in this PR to not have automated testing? |
|
There should be automatic CI running – a merge from |
|
Unfortunately creating an automated test to expose this error requires setting up an upstream. This fix applies a widely used method for preserving the data in memory in a cleanup pool, correcting the bug caused by aggressive cleanup in nginx. The same method is used in https://github.com/nginx/nginx/blob/master/src/http/modules/ngx_http_geoip_module.c#L643-L661 for example @evanmiller I'll write another commit to TitanFile:master to trigger ci. |
|
CI looks good, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRC32 values are now correctly stored for upstream requests.