Add UnixFileType so things work more smoothly on Windows. #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using argparse.FileType, this implements a subclass which ensures that newlines on Windows are '\n' instead of '\r\n'.
flamegraph.pl cannot parse the logs generated with carriage returns, so this PR prevents users on Windows from needing to do an extra step before running flamegraph.pl.
The implementation of the
__call__
method was copy/pasted from Python's standard library.I think a functionally equivalent change would be to define this function:
and pass
type=file_for_writing
for the--output
argument.