Skip to content

Add ability to modify the text through preferences (Add-on Manager), and refactor code to use the Add-on SDK. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jf
Copy link

@jf jf commented Mar 18, 2015

Hi @evacchi , dunno if you're still going to stick with the text label idea, given the discussion in #1, but... this finally adds the ability to edit the text through a preference system. Much easier than having to go to about:config, and then manually creating the string value or editing it yourself.

I realize this is a major rewrite (only 2 things have stayed the same - the require("chrome") line, and the (very appreciated) fact that the info about how to get at the dock is still there), so just let me know what you think. Thanks.

@jf
Copy link
Author

jf commented Mar 23, 2015

Sorry - realized that the functionality wasnt totally complete as yet and fixed it.

@Noitidart
Copy link

Excellent work jf!

@Noitidart
Copy link

It is always so nice to see collaboration, one person makes something others improve it!

@jf
Copy link
Author

jf commented Mar 23, 2015

Thanks, @Noitidart . Indeed, I'm very grateful to @evacchi for the work and for making it available and opensource....

@jf
Copy link
Author

jf commented Apr 23, 2015

ping, @evacchi . Can you spare some time to take a look at this? It'll be a quick one.

@evacchi
Copy link
Owner

evacchi commented Apr 23, 2015

sorry man, I've been very busy lately. You have basically rewritten the whole thing, so it seems to me unfair to just merge your pull request. I'd say go ahead and make it your own :) I could link the readme to your repo; but if you really want me to I'll be happy to merge it

@jf
Copy link
Author

jf commented Apr 29, 2015

Thanks, evacchi. If you're busy, I'd like to make it my own then. Can't say that there's anything more to do, but at least I'll be watching over it!

@jf
Copy link
Author

jf commented Apr 29, 2015

hi, @evacchi, fyi the repo is now up at https://github.com/jf/fosx-label. I want to thank you, truly, for your work, and for showing that this was even possible in the first place! Without you, this would not have been possible....

@evacchi
Copy link
Owner

evacchi commented Apr 29, 2015

I have updated the readme to point to your new version! Nice job and keep it up!

@jf
Copy link
Author

jf commented Apr 29, 2015

Thank you, evacchi! And again, thank you for everything that you've done!

@jf jf closed this Apr 29, 2015
@Noitidart
Copy link

@jf you should credit @evacchi in the readme of your repo and the AMO listing. This was purely driven by him. Even my work in Profilist was all due to him. I love your addon name very clever.

@evacchi
Copy link
Owner

evacchi commented Sep 10, 2016

I think jf did credit me enough, so that's ok :)

@Noitidart
Copy link

@jf you should merge my work from here to yours - https://addons.mozilla.org/en-US/firefox/addon/os-x-dock-icon-changer/?src=ss

It allows changing the dock icon too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants