Update bullseye submodule and cloning to https #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same sort of fix is needed for the other branches as well, it is likely easier to cherry-pick across all the branches |
Notes: * This is because GitLab has removed support for the insecure 'git://' protocol
Notes: 1. It seems like something changed in CMakes build behavior here
Notes: 1. This is likely from the change here: ev3dev/grx@28b0686#diff-02a99699ea96689f62c694983532fedec8e3b84b46ccc23d10f1ced786c82473L329 where grx is updated to take a uint8[] instead of a uint8*[] for Context? new(); the commit mentions that this is a breaking change that removes support for the unused planar memory objects.
Doom4535
force-pushed
the
ev3dev-bullseye
branch
from
12634f2 to
31020db
Compare
dlech
reviewed
Jun 18, 2025
Comment on lines
+177
to
179
| uint8 addr[4]; | ||
| addr[0] = *context_mem_addr; | ||
| context = Context.new_full (mode, width, height, addr); |
There was a problem hiding this comment.
Suggested change
| uint8 addr[4]; | |
| addr[0] = *context_mem_addr; | |
| context = Context.new_full (mode, width, height, addr); | |
| context = Context.new_full (mode, width, height, context_mem_addr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: