Skip to content

switch to x3dom 1.7.1 until problems in 1.7.2 are worked out #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2016

Conversation

bmegli
Copy link
Member

@bmegli bmegli commented Dec 23, 2016

in recently released (19.12.2016) 1.7.2 x3dom src loading is broken

this fixes x3dom library to 1.7.1 version until I have time to migrate
x3d models and files to glb format or x3dom src loading is corrected

The x3dom issue for reference

in recently released (19.12.2016)  1.7.2 x3dom src loading is broken

this fixes x3dom library to 1.7.1 version until I have time to migrate
x3d models and files to glb format or x3dom src loading is fixed
@bmegli
Copy link
Member Author

bmegli commented Dec 23, 2016

Before this commit we were using whatever the newest released x3dom version is, this pull would fix it to version 1.7.1 (the one before 19.12.16).

In currenlty linked 1.7.2 3D models on mapping project page are not loaded.

I am going to switch back to newest released x3dom as soon as I have time to migrate to glb 3D models or it's fixed but this can take me some time.

I see there's also some problem with http://www.instantreality.org/ link, I am not sure if it's temporary or something has changed

@dlech
Copy link
Member

dlech commented Dec 23, 2016

I see there's also some problem with http://www.instantreality.org/ link

It checks out fine for me locally, so we might need to just put it on the travis "bad" list. Although this site is not https, so it is surprising that we are having trouble with it.

@WasabiFan
Copy link
Member

@dlech it was legitimately down last night but works now.

@WasabiFan WasabiFan merged commit e592f60 into ev3dev:master Dec 23, 2016
@bmegli
Copy link
Member Author

bmegli commented Dec 23, 2016

Thanks!

As for the link - yes, it seems that Instant Reality site was temporarily down.

@WasabiFan
Copy link
Member

@bmegli Side-note: Your lidar tutorial is some of our most-linked-to content on the site 😉 it's in the top four, just above the news feed.

@bmegli
Copy link
Member Author

bmegli commented Dec 28, 2016

@WasabiFan I suppose it must have been me linking it from mapping-modules repository, mapping-ui repository and mapping project page repository 😉, uhm... 2 or 3 times to various sections in the last.

As for the x3dom I will be staying with 1.7.1. for some time. Glb support in 1.7.2. also has some issues and src is not yet "reimplemented" fully. This is IT I like - everything wired to everything and everything under construction 😉

@bmegli bmegli deleted the fix-x3d branch December 28, 2016 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants