Skip to content

Commit adb7ea1

Browse files
egrumbachgregkh
authored andcommitted
iwlwifi: mvm: don't send GEO_TX_POWER_LIMIT to old firmwares
commit eca1e56 upstream. Old firmware versions don't support this command. Sending it to any firmware before -41.ucode will crash the firmware. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=201975 Fixes: 66e8390 ("iwlwifi: fix wrong WGDS_WIFI_DATA_SIZE") CC: <stable@vger.kernel.org> #4.19+ Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent e1240a1 commit adb7ea1

File tree

1 file changed

+9
-0
lines changed
  • drivers/net/wireless/intel/iwlwifi/mvm

1 file changed

+9
-0
lines changed

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -952,6 +952,15 @@ static int iwl_mvm_sar_geo_init(struct iwl_mvm *mvm)
952952
int ret, i, j;
953953
u16 cmd_wide_id = WIDE_ID(PHY_OPS_GROUP, GEO_TX_POWER_LIMIT);
954954

955+
/*
956+
* This command is not supported on earlier firmware versions.
957+
* Unfortunately, we don't have a TLV API flag to rely on, so
958+
* rely on the major version which is in the first byte of
959+
* ucode_ver.
960+
*/
961+
if (IWL_UCODE_SERIAL(mvm->fw->ucode_ver) < 41)
962+
return 0;
963+
955964
ret = iwl_mvm_sar_get_wgds_table(mvm);
956965
if (ret < 0) {
957966
IWL_DEBUG_RADIO(mvm,

0 commit comments

Comments
 (0)