Skip to content

Commit eca1e56

Browse files
egrumbachKalle Valo
authored andcommitted
iwlwifi: mvm: don't send GEO_TX_POWER_LIMIT to old firmwares
Old firmware versions don't support this command. Sending it to any firmware before -41.ucode will crash the firmware. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=201975 Fixes: 66e8390 ("iwlwifi: fix wrong WGDS_WIFI_DATA_SIZE") CC: <stable@vger.kernel.org> #4.19+ Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
1 parent cddfb28 commit eca1e56

File tree

1 file changed

+9
-0
lines changed
  • drivers/net/wireless/intel/iwlwifi/mvm

1 file changed

+9
-0
lines changed

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -881,6 +881,15 @@ static int iwl_mvm_sar_geo_init(struct iwl_mvm *mvm)
881881
int ret, i, j;
882882
u16 cmd_wide_id = WIDE_ID(PHY_OPS_GROUP, GEO_TX_POWER_LIMIT);
883883

884+
/*
885+
* This command is not supported on earlier firmware versions.
886+
* Unfortunately, we don't have a TLV API flag to rely on, so
887+
* rely on the major version which is in the first byte of
888+
* ucode_ver.
889+
*/
890+
if (IWL_UCODE_SERIAL(mvm->fw->ucode_ver) < 41)
891+
return 0;
892+
884893
ret = iwl_mvm_sar_get_wgds_table(mvm);
885894
if (ret < 0) {
886895
IWL_DEBUG_RADIO(mvm,

0 commit comments

Comments
 (0)