Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUCK-2154 on upload a file the categorization can be started immediately. #32

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

konfusio
Copy link
Contributor

motivation

endpoint to start categorization is already deprecated for a while.
Prefered way is to start categorization directly on upload.

change

removed rest call to start categorization
added flag to upload information so categorization will started directly

@konfusio konfusio self-assigned this Nov 18, 2021
dbohry
dbohry previously approved these changes Nov 18, 2021
MikeKrueger75
MikeKrueger75 previously approved these changes Nov 18, 2021
Copy link
Contributor

@MikeKrueger75 MikeKrueger75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@MikeKrueger75 MikeKrueger75 dismissed stale reviews from dbohry and themself via 6a8e382 November 18, 2021 13:37
@MikeKrueger75 MikeKrueger75 merged commit ca46472 into master Nov 18, 2021
@MikeKrueger75 MikeKrueger75 deleted the start-categorization-on-upload branch November 18, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants