Skip to content

Conversation

@lupemba
Copy link
Member

@lupemba lupemba commented Oct 29, 2025

This PR contains a number of smaller changes.

  • Rename read_dataset to open_dataset since the method just opens the dataset and only reads the necessary meta data.
  • Add maskingvalue argument to open_dataset. I often put it to NaN in my workflows so users are probably also going to need it.
  • Add as_array method so we can remove from juliacall import Main from the example.
  • Add close_dataset method
  • Add shape method to wrap Main.size. The Main.size function is much more general in julia compared to directly accessing the .size property of a Julia array. E.g. Main.size works for all julia array types and not just the standard one.
  • Update README example to include new methods.
  • Add a small section with np.array to the example.

@lupemba lupemba requested a review from pacospace October 29, 2025 13:25
Copy link
Member

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@pacospace pacospace merged commit 99a4b7f into main Oct 30, 2025
pacospace pushed a commit that referenced this pull request Nov 6, 2025
### Features

- CI print code coverage ([#8](#8)) ([50052c5](50052c5))
- Add tests with pytest and add github CI action. ([#7](#7)) ([7451e0f](7451e0f))
- Bump MetopDatasets.jl to 0.2.1 ([#6](#6)) ([eb670ad](/commit/eb670adaff26a93225880ce68ddfd3801d0e389e))
- Improve basic functions and extend readme example ([#3](#3)) ([99a4b7f](99a4b7f))
- Migrate from internal Gitlab ([#2](#1)) ([0753149](0753149))
@pacospace pacospace mentioned this pull request Nov 6, 2025
pacospace added a commit that referenced this pull request Nov 6, 2025
### Features

- CI print code coverage ([#8](#8)) ([50052c5](50052c5))
- Add tests with pytest and add github CI action. ([#7](#7)) ([7451e0f](7451e0f))
- Bump MetopDatasets.jl to 0.2.1 ([#6](#6)) ([eb670ad](/commit/eb670adaff26a93225880ce68ddfd3801d0e389e))
- Improve basic functions and extend readme example ([#3](#3)) ([99a4b7f](99a4b7f))
- Migrate from internal Gitlab ([#2](#1)) ([0753149](0753149))

Co-authored-by: Francesco Murdaca <francesco.murdaca@eumetsat.int>
@pacospace pacospace deleted the skl-improve-interface branch November 6, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants