-
Notifications
You must be signed in to change notification settings - Fork 30
Implement oracle factories #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto review-factories
Contributor
Author
|
Closing for now. Factories are out of scope for this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following:
FeedRegistry.sol, aGovernablecontract that holds a mapping (base,quote) -> FeedIdentifier.FeedIdentifier.sol, a library that wraps address/bytes32 in the same data type. This is necessary because the registry for Chainlink and Chronicle stores addresses, while the registry for Pyth and Redstone stores bytes32s.BaseAdapterFactory.sol, an abstract base contract for oracle factories.OracleMultiFactory.sol, aGovernablemeta-factory. It maintains a mapping of enabled factories and records all deployed oracles.IOracleFactoryextraDatacontains abi-encoded extra deployment parameters e.g.maxStaleness.OracleMultiFactoryIOracleFactoryLidoOracleto the deployments