Implement cross pricing adapter #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpawlowski
approved these changes
Mar 25, 2024
haythemsellami
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CrossAdapter prices a pair by calling through an intermediate oracle.
For example, to price wstETH/USD, CrossAdapter may price wstETH/stETH and then stETH/USD. Another common one is WBTC/USD decomposed into two Chainlink feeds: WBTC/BTC and BTC/USD.
I thought about supporting cross pricing with 3 legs, however I could not come up with examples for pairs that would need that. Only reason is a vault using a non-standard reference asset, but that is too esoteric to make it in scope